crypto-common: migrate to hybrid-array; MSRV 1.65
#1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
commented
May 30, 2023
tarcieri
commented
May 30, 2023
tarcieri
force-pushed
the
crypto-common/hybrid-array
branch
3 times, most recently
from
5e808f0
to
0856ad0
Compare
newpavlov
reviewed
May 31, 2023
tarcieri
force-pushed
the
crypto-common/hybrid-array
branch
3 times, most recently
from
5a6327f
to
0c9a9bb
Compare
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 5, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 5, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
|
Since |
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 5, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
force-pushed
the
crypto-common/hybrid-array
branch
from
0c9a9bb
to
9a65db3
Compare
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 5, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Sep 5, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
|
|
|
Yes,
|
|
Ok. Should we migrate to |
|
Personally I'd prefer to go straight to I can do |
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Oct 8, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Oct 8, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Oct 8, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
added a commit
to RustCrypto/utils
that referenced
this pull request
Oct 8, 2023
Builds on RustCrypto/traits#1319. Migrates the following crates away from using `generic-array` to using `hybrid-array` instead: - `block-buffer` - `block-padding` - `dbl` - `inout`
tarcieri
force-pushed
the
crypto-common/hybrid-array
branch
2 times, most recently
from
2854b76
to
11330b0
Compare
tarcieri
changed the title
hybrid-array; MSRV 1.65hybrid-array; MSRV 1.65
|
The |
Replaces `generic-array` with `hybrid-array`, which is built on a combination of `typenum` and const generics, providing a degree of interoperability between the two systems. `hybrid-array` is designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncracies.
tarcieri
force-pushed
the
crypto-common/hybrid-array
branch
from
11330b0
to
3ada46b
Compare
|
@newpavlov this is ready now |
The `ArraySize` trait already bounds on `'static`
newpavlov
approved these changes
Oct 26, 2023
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
generic-arraywithhybrid-array, which is built on a combination oftypenumand const generics, providing a degree of interoperability between the two systems.hybrid-arrayis designed to be a largely drop-in replacement, and the number of changes required to switch are relatively minimal aside from some idiosyncracies.